Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve URL condition #19

Merged
merged 1 commit into from
Dec 21, 2015
Merged

Improve URL condition #19

merged 1 commit into from
Dec 21, 2015

Conversation

zenangst
Copy link
Contributor

With this PR, we look for another delimiter when determining if its a URL or a URN.

@vadymmarkov
Copy link
Contributor

@zenangst Do we have some tests? 😄

@zenangst
Copy link
Contributor Author

We have tests for parsing both kinds of types yes.

@vadymmarkov
Copy link
Contributor

@zenangst 👍

vadymmarkov added a commit that referenced this pull request Dec 21, 2015
@vadymmarkov
Merge pull request #19 from hyperoslo/improve/url-parsing
3acfc7d 
Improve URL condition
@vadymmarkov vadymmarkov merged commit 3acfc7d into master Dec 21, 2015
@vadymmarkov vadymmarkov deleted the improve/url-parsing branch December 21, 2015 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenangst @vadymmarkov